feat: root to agent upsert key rpc - #243
Merged
Merged
Conversation
Signed-off-by: fabenan-f <63860771+fabenan-f@users.noreply.github.com>
This comment was marked as spam.
This comment was marked as spam.
Signed-off-by: fabenan-f <63860771+fabenan-f@users.noreply.github.com>
fabenan-f
marked this pull request as ready for review
September 15, 2026 15:10
fabenan-f
requested review from
NamanBalaji,
apatsap and
jithinkunjachan
and removed request for
NamanBalaji and
apatsap
September 15, 2026 15:10
jithinkunjachan
approved these changes
Sep 16, 2026
jithinkunjachan
left a comment
jithinkunjachan
left a comment
Contributor
There was a problem hiding this comment.
Nice changes except for one change
|
|
||
| UNIQUE (tenant_id, name), | ||
| UNIQUE (tenant_id, id), | ||
| FOREIGN KEY (tenant_id, parent_id) REFERENCES keys(tenant_id, id) |
Contributor
There was a problem hiding this comment.
shall we remove only remove this constraints for agents
| stmt := ` | ||
| INSERT INTO keys (id, tenant_id, kind, name, parent_id, managed_by, labels, life_cycle_state, processing_status, processing_job_id, created_at, updated_at) | ||
| VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10, $11, $12) | ||
| -- keeps the enclosing transaction alive on conflict so callers can reconcile |
NamanBalaji
approved these changes
Sep 16, 2026
apatsap
approved these changes
Sep 16, 2026
apatsap
requested changes
Sep 16, 2026
Signed-off-by: fabenan-f <63860771+fabenan-f@users.noreply.github.com>
apatsap
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This introduces a new
krypton.v1.agents.keys.KeyServicefor root→agent key pushes with idempotentUpsertKey.